Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce index_files function not restricted to JLSO #29

Merged
merged 4 commits into from
Jul 22, 2021
Merged

Introduce index_files function not restricted to JLSO #29

merged 4 commits into from
Jul 22, 2021

Conversation

nickrobinson251
Copy link
Contributor

No description provided.

nickrobinson251
nickrobinson251 commented Jul 21, 2021
View reviewed changes
test/indexing.jl Outdated Show resolved Hide resolved
oxinabox
oxinabox reviewed Jul 21, 2021
View reviewed changes
test/indexing.jl Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jul 21, 2021 •
edited
Loading

Codecov Report

Merging #29 (6fec26e) into main (9283756) will increase coverage by 0.10%.
The diff coverage is 66.66%.

❗ Current head 6fec26e differs from pull request most recent head 4d21212. Consider uploading reports for the commit 4d21212 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main      #29      +/-   ##
==========================================
+ Coverage   94.92%   95.03%   +0.10%     
==========================================
  Files           5        5              
  Lines         138      141       +3     
==========================================
+ Hits          131      134       +3     
  Misses          7        7
Impacted Files Coverage Δ
src/Checkpoints.jl 91.89% <ø> (ø)
src/indexing.jl 91.89% <66.66%> (-2.23%) ⬇️
src/handler.jl 96.77% <0.00%> (+3.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9283756...4d21212. Read the comment docs.

oxinabox
oxinabox approved these changes Jul 21, 2021
View reviewed changes
Copy link
Member

@oxinabox oxinabox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this is basically just as much code as it would be to make index_checkpoint_files use index_all_file

@nickrobinson251 nickrobinson251 merged commit 732fdf4 into main Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oxinabox oxinabox oxinabox approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nickrobinson251 @oxinabox